[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/1] qemu: reject blockiotune if qemu too old



On 05/04/2012 04:04 PM, Jiri Denemark wrote:
> On Fri, May 04, 2012 at 11:21:51 -0600, Eric Blake wrote:
>> Commit 4c82f09e added a capability check for qemu per-device io
>> throttling, but only applied it to domain startup.  As mentioned
>> in the previous commit, we stil end up with an internal error
> 
> s/stil/still/
> 
>> if the monitor command doesn't also exist, not to mention the
>> confusion of allowing tuning on inactive domains only to then
>> be rejected when starting the domain.
>>
>> * src/qemu/qemu_driver.c (qemuDomainSetBlockIoTune): Reject
>> offline tuning if online can't match it.
>> ---
>>  src/qemu/qemu_driver.c |    8 +++++++-
>>  1 files changed, 7 insertions(+), 1 deletions(-)
> 
> ACK

Thanks; series pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]