[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] openvz: simplify openvzDomainDefineCmd by using virCommandPtr



On 05/05/2012 03:30 AM, Guido Günther wrote:
> ---
> While working on setting filesystem quotas I came accross this and I
> figured I'll send this in advance because of the diffstat.
> Cheers,
>  -- Guido

> +    } else {
> +        cmd = openvzDomainDefineCmd(vmdef);
> +        if (cmd == NULL)
>              goto cleanup;

This misses out on the virReportOOMError(); you could just delete this
if clause, and directly proceed to:

> -        }
>  
> -        if (virRun(prog, NULL) < 0) {
> +        if (virCommandRun(cmd, NULL) < 0)

this, which will properly report the OOM in case cmd is NULL.

ACK with that simplification.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]