[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] domain_conf: add "usbredir" to list of valid spice channels



On 05/07/2012 06:33 AM, Alon Levy wrote:
> Add "usbredir" channel to list of recognized spice channels.
> 
> RHBZ: 819498
> 
> Signed-off-by: Alon Levy <alevy redhat com>
> ---
>  src/conf/domain_conf.c |    3 ++-
>  src/conf/domain_conf.h |    1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)

Missing a change to the documentation in docs/formatdomain.html.in, and
to the RelaxNG grammar in docs/schemas/domaincommon.rng.  It would also
be nice to see if there is an existing test in tests/qemuxml2argvdata/*
that can be enhanced to cover the new XML, and/or add a new test.

I'm not sure whether this counts as a simple enough addition to include
in 0.9.12, or whether we should wait until after the release to take it,
but the code patch itself looks reasonable.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]