[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Report error when parsing character device target type



On 05/09/2012 11:48 AM, Jim Fehlig wrote:
> No useful error was being reported when an invalid character device
> target type is specified in the domainXML. E.g.
> 
>     ...
>     <console type="pty">
>       <source path="/dev/pts/2"/>
>       <target type="kvm" port="0"/>
>     </console>
>     ...
> 
> resulted in
> 
> error: Failed to define domain from x.xml
> error: An error occurred, but the cause is unknown
> 
> With this small patch, the error is more helpful
> 
> error: Failed to define domain from x.xml
> error: XML error: unknown target type 'kvm' specified for character device
> ---
>  src/conf/domain_conf.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 976e42b..54ac1db 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -4895,6 +4895,9 @@ virDomainChrDefParseTargetXML(virCapsPtr caps,
>      if ((def->targetType =
>           virDomainChrTargetTypeFromString(caps, vmdef,
>                                            def->deviceType, targetType)) < 0) {
> +        virDomainReportError(VIR_ERR_XML_ERROR,
> +                             _("unknown target type '%s' specified for character device"),
> +                             targetType);
>          goto error;

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]