[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib 3/4] Add guest capabilities API



On Wed, May 9, 2012 at 5:54 PM, Christophe Fergeau <cfergeau redhat com> wrote:
> On Wed, May 09, 2012 at 04:16:15AM +0300, Zeeshan Ali (Khattak) wrote:
>> From: "Zeeshan Ali (Khattak)" <zeeshanak gnome org>
>>
>> Not quite complete but its a good start.
>> +{
>> +    g_debug("Init GVirConfigCapabilitiesGuest=%p", conn);
>> +
>> +    conn->priv = GVIR_CONFIG_CAPABILITIES_GUEST_GET_PRIVATE(conn);
>> +}
>> +
>> +GVirConfigDomainOsType
>
> I don't think this is the right return type, this enum currently translates to "hvm",
> "linux" and "exe", while "xen" and "uml" should also be valid (re-reading
> libvirt source code, it might have been better to use a string instead of
> this enum).
> The only valid values for guest caps os type are "xen" and "hvm"

RTF RNG :)

  <define name='guestcaps'>
    <element name='guest'>
      <ref name='ostype'/>
...

  <define name='ostype'>
    <element name='os_type'>
      <choice>
        <value>xen</value> <!-- Xen 3.0 pv -->
        <value>linux</value> <!-- same as 'xen' - legacy -->
        <value>hvm</value> <!-- unmodified OS -->
        <value>exe</value> <!-- For container based virt -->
        <value>uml</value> <!-- user mode linux -->


-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]