[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib 2/4] Add host capabilities API



On Wed, May 09, 2012 at 11:00:51PM +0300, Zeeshan Ali (Khattak) wrote:
> On Wed, May 9, 2012 at 7:10 PM, Christophe Fergeau <cfergeau redhat com> wrote:
> 
> > +const gchar *
> > +gvir_config_capabilities_cpu_feature_get_name(GVirConfigCapabilitiesCpuFeature *caps)
> >
> > s/caps/feature
> 
> I was thinking of using 'caps' for all GVirConfigCapabilities*
> instances but no strong feelings so I'll change..

At the moment, it's not consistent at all, in some files some methods have
a caps argument, and some others a feature argument (and sometimes 'conn'
is used). Since some changes are needed, I have a slight preference for
more specific names


> 
> > +{
> >
> > g_return_val_if_fail(GVIR_CONFIG_IS_CAPABILITIES_CPU_FEATURE(feature);
> >
> > +    return gvir_config_object_get_attribute(GVIR_CONFIG_OBJECT(caps),
> > +                                            NULL,
> > +                                            "name");
> > +}
> >
> > Can you add the 2 other attributes while you are at it?
> 
> Which other 2 attributes? AFAICT from RNG and 'capabilities' xml on my
> machine, those attributes only exists in guest features.

Ah sorry, confusion on my side, forget this comment ;)

Christophe

Attachment: pgphNArDmCRij.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]