[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib 4/5] Allow unsetting of string & object properties



On Thu, May 10, 2012 at 11:49:43PM +0300, Zeeshan Ali (Khattak) wrote:
> On Thu, May 10, 2012 at 9:58 PM, Christophe Fergeau <cfergeau redhat com> wrote:
> > The 2nd one only has the gvir_config_object_attach_replace changes,
> > and it has some changes: I reordered the parameter to _attach_replace to
> > make the order similar to most other functions, and I changed the
> > GVIR_CONFIG_OBJECT() casts to (GVirConfigObject *) otherwise we'd get a
> > runtime check when passing a NULL pointer.
> 
> Thats not true. I was also afraid of that and I wrote a test app to
> see if G_TYPE_CHECK_INSTANCE_CAST minds a null but it didn't.

Indeed, I checked that myself too. For some reason I was convinced it would
trigger a warning. Just change it back then ;)

Christophe

Attachment: pgpooQwOGGXpM.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]