[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib 5/5] Add gvir_config_domain_os_get_boot_devices()



On Fri, May 11, 2012 at 01:32:34PM +0100, Daniel P. Berrange wrote:
> If I look at the docs for GTK, I see GTK-DOC is including details of
> the annotations:
> 
> eg
> 
>   http://developer.gnome.org/gtk3/stable/GtkWindow.html#gtk-window-get-default-icon-list
> 
>   "Returns: copy of default icon list. [element-type GdkPixbuf][transfer container]"
> 
> 
> IMHO this is sufficient and we don't need to explicitly mention the
> transfer rules in the docs string.

I know it's in there, but if you are not familiar with gtk conventions at
all, you have to first figure out what that means exactly, and then you
have to find the correct way of free-ing the container and what it contains
(which is not necessarily g_object_unref, it can contain strings, boxed
types, ...). That's why I really prefer having it mentioned explicitly,
memory handling is boring enough/error-prone enough so anything that makes
it simpler is a plus in my opinion.

Christophe

Attachment: pgpSpwH6wD5WH.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]