[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: fix stamp file name



On Fri, May 11, 2012 at 08:24:06AM -0600, Eric Blake wrote:
> Ever since commit c964b6a, make was trying to find the timestamp
> of '""./apibuild.py".stamp"', but only touching 'apibuild.py.stamp',
> and thus always rebuilding.  Reported by Daniel P. Berrange.
> 
> * docs/Makefile.am (APIBUILD, APIBUILD_STAMP): Omit bogus quotes.
> ---
> 
> Pushing under the trivial rule.  'make --debug' to the rescue!
> 
>  docs/Makefile.am |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/docs/Makefile.am b/docs/Makefile.am
> index 9bcc866..a03ca3e 100644
> --- a/docs/Makefile.am
> +++ b/docs/Makefile.am
> @@ -1,6 +1,6 @@
>  ## Process this file with automake to produce Makefile.in
> 
> -## Copyright (C) 2005-2011 Red Hat, Inc.
> +## Copyright (C) 2005-2012 Red Hat, Inc.
>  ## See COPYING.LIB for the License of this software
> 
>  SUBDIRS= schemas
> @@ -200,8 +200,8 @@ python_generated_files = \
>  		$(srcdir)/libvirt-qemu-api.xml \
>  		$(srcdir)/libvirt-qemu-refs.xml
> 
> -APIBUILD="$(srcdir)/apibuild.py"
> -APIBUILD_STAMP="$(APIBUILD).stamp"
> +APIBUILD=$(srcdir)/apibuild.py
> +APIBUILD_STAMP=$(APIBUILD).stamp
> 
>  $(python_generated_files): $(APIBUILD_STAMP)

Ahhhh, I was going mad trying to spot the flaw :-)

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]