[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 3/3] qemu: Don't skip detection of virtual cpu's on non KVM targets

On 05/11/2012 04:12 PM, Eric Blake wrote:
On 05/11/2012 07:23 AM, Peter Krempa wrote:
This patch lifts the limit of calling thread detection code only on KVM
guests. With upstream qemu the thread mappings are reported also on
non-KVM machines.

QEMU adoppted the thread_id information from the kvm branch.


To remain compatible with older upstream versions of qemu the check is
attempted but the failure to detect threads (or even run the monitor
command - on older versions without SMP support) is treated non-fatal
and the code reports one vCPU with pid of the hypervisor (in same
fashion this was done on non-KVM guests).
Diff to v1:
- Try to detect vCPU threads on all types of guests but
fall back gracefully if the hypervisor doesn't support it.
  src/qemu/qemu_process.c |   21 ++++++++-------------
  1 files changed, 8 insertions(+), 13 deletions(-)


Thanks; I fixed the nits and pushed the series.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]