[libvirt] [PATCH libvirt 1/2] domain: add <forward> element for user mode networking

[Daniel P. Berrange]

On Mon, May 14, 2012 at 01:29:11PM +0200, Marc-André Lureau wrote:
> Hi
> 
> Ah, I just realized that there is 'guestfwd' support already, so we
> may want to use the same syntax
> 
> <channel type='tcp'>
>   <source mode='bind' host='127.0.0.1' service='2222'/>
>   <target type='hostfwd' address='10.0.2.15' port='22'/>
> </channel>
> 
> It seems a bit contrieved to me, it is harder to interpret. 'host'
> address and guest 'address' are no longer optional. There is no way to
> specify the protocol.

This device was a bit of a nasty hack that we probably shouldn't
have done.

> However, I imagined we may want to move the <forward/> element I added
> to the devices top level, since it is not bound to an interface device
> in fact.

I like your use of <forward> inside the <interface> element since
that makes it applicable to more than just the  type=user networking.
eg the libvirt type=default NAT networking could also use this
syntax

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|