[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 5/6] Add security driver APIs for getting mount options



On Fri, May 11, 2012 at 10:43:50PM -0400, Stefan Berger wrote:
> On 05/11/2012 06:10 AM, Daniel P. Berrange wrote:
> >From: Daniel Walsh<dwalsh redhat com>
> >
> >Some security drivers require special options to be passed to
> >the mount system call. Add a security driver API for handling
> >this data.
> >
> >Signed-off-by: Daniel P. Berrange<berrange redhat com>
> >---
> >@@ -423,3 +422,16 @@ int virSecurityManagerSetImageFDLabel(virSecurityManagerPtr mgr,
> >      virSecurityReportError(VIR_ERR_NO_SUPPORT, __FUNCTION__);
> >      return -1;
> >  }
> >+
> >+char *virSecurityManagerGetMountOptions(virSecurityManagerPtr mgr,
> >+                                        virDomainDefPtr vm)
> >+{
> >+    if (mgr->drv->domainGetSecurityMountOptions)
> >+        return mgr->drv->domainGetSecurityMountOptions(mgr, vm);
> >+
> >+/*
> >+  I don't think this is an error, these should be optional
> >+  virSecurityReportError(VIR_ERR_NO_SUPPORT, __FUNCTION__);
> >+*/
> 
> Indentation -- or is my email program distorting it?

This is a genuine whitespace bug.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]