[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] libvirt-guests: Remove LISTFILE if it's empty when stopping service



On 2012年05月15日 00:13, Eric Blake wrote:
On 05/14/2012 01:21 AM, Osier Yang wrote:
$LISTFILE is created even no domain is running, and the empty
$LISTFILE could cause improper service status.

     stoped ,with saved guests

Do we really say "stoped", or is that a typo in the commit message?

Yes, it's a typo. :-)



Which is not right, as there is no domain was saved.
---
  tools/libvirt-guests.init.sh |   42 +++++++++++++++++++++++-------------------
  1 files changed, 23 insertions(+), 19 deletions(-)


Missing quotes:

+    if [ -s $LISTFILE ]; then

if [ -s "$LISTFILE" ]; then


+    else
+        rm -f $LISTFILE

rm -f "$LISTFILE"

Looks like the rest of the patch is just reindentation after the added
if statement; ACK with the quoting fixes.


Thanks, pushed with the quotes added.

Regards,
Osier


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]