[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Set a sensible default master start port for ehci companion controllers



On Mon, May 14, 2012 at 03:47:57PM -0600, Eric Blake wrote:
> On 05/14/2012 06:24 AM, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange" <berrange redhat com>
> > 
> > The uhci1, uhci2, uhci3 companion controllers for ehci1 must
> > have a master start port set. Since this value is predictable
> > we should set it automatically if the app does not supply it
> > ---
> >  src/conf/domain_conf.c                             |   22 ++++++++++++++++++
> >  .../qemuxml2argv-usb-ich9-ehci-addr.xml            |   24 +++++---------------
> >  2 files changed, 28 insertions(+), 18 deletions(-)
> 
> ACK.  But shouldn't we also have a test in qemuxml2xmltest, by using a
> file in qemuxml2xmloutdata/, that shows that we generate the correct
> start port on output in response to a user omitting information that we
> can determine by default?

Now I added a test case for the previous USB patch it automatically
also tested the scenario you describe here.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]