[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] qemu: Add support for -no-user-config



On Thu, Apr 26, 2012 at 10:48:15 -0600, Eric Blake wrote:
> On 04/26/2012 08:28 AM, Jiri Denemark wrote:
> > Thanks to this new option we are now able to use modern CPU models (such
> > as Westmere) defined in external configuration file.
> > ---
> 
> I agree with your decision to not push this patch until we have a
> documented qemu pull request incorporating the qemu side of things, to
> ensure that we will match qemu 1.1 semantics.
> 
> >  src/qemu/qemu_capabilities.c |    7 ++++++-
> >  src/qemu/qemu_capabilities.h |    1 +
> >  src/qemu/qemu_command.c      |   11 ++++++-----
> >  src/qemu/qemu_driver.c       |    2 +-
> >  4 files changed, 14 insertions(+), 7 deletions(-)
> 
> When we _do_ get ready to push this, please add a file to
> tests/qemuhelpdata corresponding to qemu 1.1, so that we can prove that
> we properly detect the new flag bit according to -help output.
> 
> ACK to the code that you do have, though.

Thanks. Since the qemu side of this is now included in qemu-1.1-rc2, I went
ahead and pushed this patch with appropriate changes to qemuhelptest:

commit 63b4243624b8fdabebaf5e6ec912095b2b5fdf5c
Author: Jiri Denemark <jdenemar redhat com>
Date:   Thu Apr 26 12:11:49 2012 +0200

    qemu: Add support for -no-user-config
    
    Thanks to this new option we are now able to use modern CPU models (such
    as Westmere) defined in external configuration file.
    
    The qemu-1.1{,-device} data files for qemuhelptest are filled in with
    qemu-1.1-rc2 output for now. I will update those files with real
    qemu-1.1 output once it is released.

 cfg.mk                             |    3 +-
 src/qemu/qemu_capabilities.c       |    7 +-
 src/qemu/qemu_capabilities.h       |    1 +
 src/qemu/qemu_command.c            |   11 +-
 src/qemu/qemu_driver.c             |    2 +-
 tests/qemuhelpdata/qemu-1.1        |  268 ++++++++++++++++++++++++++++++++++++
 tests/qemuhelpdata/qemu-1.1-device |  160 +++++++++++++++++++++
 tests/qemuhelptest.c               |   75 ++++++++++

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]