[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv5 2/2] Adds support to param 'vcpu_time' in qemu_driver.



On 05/18/2012 03:09 AM, Hu Tao wrote:
> On Thu, May 17, 2012 at 03:56:48PM -0600, Eric Blake wrote:
>> From: Hu Tao <hutao cn fujitsu com>
>>
>> This involves setting the cpuacct cgroup to a per-vcpu granularity,
>> as well as summing the each vcpu accounting into a common array.
>> Now that we are reading more than one cgroup file, we double-check
>> that cpus weren't hot-plugged between reads to invalidate our
>> summing.
>>
>> Signed-off-by: Eric Blake <eblake redhat com>
>> ---
>>
>> diff from v4: rewrite qemu code to use fewer malloc calls, fix
>> some logic bugs
>>

> 
> ACK.

Thanks for testing the common case, even if you didn't cover the case of
offline cpus.  I've gone ahead and pushed this.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]