[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu_hotplug: Don't free the PCI device structure after hot-unplug



On 05/21/2012 09:53 AM, Peter Krempa wrote:
> The pciDevice structure corresponding to the device being hot-unplugged
> was freed after it was "stolen" from activeList. The pointer was still
> used for eg-inactive list. This patch removes the free of the structure
> and frees it only if reset fails on the device.
> ---
>  src/qemu/qemu_hotplug.c |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)

ACK.

This whole area of code is rather nasty.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]