[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Revert "rpc: Discard non-blocking calls only when necessary"



On 05/22/2012 07:34 AM, Jiri Denemark wrote:
> This reverts commit b1e374a7ac56927cfe62435179bf0bba1e08b372, which was
> rather bad since I failed to consider all sides of the issue. Thus, the
> reverted patch actually breaks more than what it fixes and clients
> (which may even be libvirtd during p2p migrations) will likely end up
> with a corrupted dispatch queue.
> ---
> 
> I will send proper replacement for the reverted patch later once I'm convinced
> it's correct (more than I was convinced the original one was correct) :-P
> 
>  src/rpc/virnetclient.c |   21 ++++++++++++---------
>  1 file changed, 12 insertions(+), 9 deletions(-)
> 

ACK for being a straight revert, although I would hold off pushing this
until the cleaner replacement has been reviewed and can be pushed at the
same time.

Just so I understand, how was this patch causing new problems?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]