[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/4] Autogenerate augeas test case from default config files

On 05/25/2012 06:36 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> When adding new config file parameters, the corresponding
> additions to the augeas lens' are constantly forgotten.
> Also there are augeas test cases, these don't catch the
> error, since they too are never updated.
> To address this, the augeas test cases need to be auto-generated
> from the example config files.
> * build-aux/augeas-gentest.pl: Helper to generate an
>   augeas test file, substituting in elements from the
>   example config files
> * src/Makefile.am, daemon/Makefile.am: Switch to
>   auto-generated augeas test cases
> * daemon/test_libvirtd.aug, daemon/test_libvirtd.aug.in,
>   src/locking/test_libvirt_sanlock.aug,
>   src/locking/test_libvirt_sanlock.aug.in,
>   src/lxc/test_libvirtd_lxc.aug,
>   src/lxc/test_libvirtd_lxc.aug.in,
>   src/qemu/test_libvirtd_qemu.aug,
>   src/qemu/test_libvirtd_qemu.aug.in: Remove example
>   config file data, replacing with a ::CONFIG:: placeholder
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---

> +++ b/build-aux/augeas-gentest.pl
> @@ -0,0 +1,51 @@
> +#!/usr/bin/perl
> +

Missing a copyright header.

Nice!  ACK, once you fix that, and silence these syntax checks:

daemon/test_libvirtd.aug.in:15:	{ "unix_sock_dir" = "/var/run/libvirt" }
maint.mk: indent with space, not TAB, in C, sh, html, py, syms and RNG
make: *** [sc_TAB_in_indentation] Error 1

maint.mk: empty line(s) or no newline at EOF
make: *** [sc_prohibit_empty_lines_at_EOF] Error 1

Also, if you rearrange qemu.conf per my comments in 3/4, you might have
to adjust the test file to match here.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]