[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Remove last usageof PATH_MAX and ban its future use



On 05/25/2012 10:43 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> Remove a number of pointless checks against PATH_MAX and
> add a syntax-check rule to prevent its use in future
> ---
>  cfg.mk                             |    5 +++++
>  src/security/virt-aa-helper.c      |    4 ++--
>  src/storage/storage_backend_scsi.c |    2 +-
>  src/xenxs/xen_xm.c                 |    2 --
>  tools/virsh.c                      |    7 ++++---
>  5 files changed, 12 insertions(+), 8 deletions(-)
> 
> diff --git a/cfg.mk b/cfg.mk
> index 07fb7b2..534dc67 100644
> --- a/cfg.mk
> +++ b/cfg.mk
> @@ -408,6 +408,11 @@ sc_prohibit_VIR_ERR_NO_MEMORY:
>  	halt='use virReportOOMError, not V'IR_ERR_NO_MEMORY		\
>  	  $(_sc_search_regexp)
>  
> +sc_prohibit_PATH_MAX:
> +	@prohibit='\<P''ATH_MAX\>'				\
> +	halt='dynamically allocate paths, do not use P'ATH_MAX	\
> +	  $(_sc_search_regexp)

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]