[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/1] build: use same perl binary throughout build



On 05/30/2012 01:05 AM, Eric Blake wrote:
> On 05/29/2012 04:03 PM, Eric Blake wrote:
>> Some of our rules used $(PERL), while others used 'perl'.  Always
>> using the variable allows a developer to point to a different (often
>> better) perl than the default one found on $PATH.
>>
>> * daemon/Makefile.am ($(srcdir)/remote_dispatch.h): s/perl/$(PERL).
>> * src/Makefile.am ($(srcdir)/remote/remote_client_bodies.h)
>> (PDWTAGS, %protocol.c, %_probes.stp): Likewise.
>> ---
>>
>> Noticed this while working on the previous patch.
>>
>>  daemon/Makefile.am |    4 ++--
>>  src/Makefile.am    |   14 +++++++-------
>>  2 files changed, 9 insertions(+), 9 deletions(-)
> 
> Needs this squashed in to work properly:
> 
> diff --git i/configure.ac w/configure.ac
> index 59962c5..7d8d26b 100644
> --- i/configure.ac
> +++ w/configure.ac
> @@ -2243,6 +2243,9 @@ AM_CONDITIONAL([WITH_PYTHON], [test "$with_python"
> = "yes"])
>  AC_SUBST([PYTHON_VERSION])
>  AC_SUBST([PYTHON_INCLUDES])
> 
> +dnl Allow perl overrides
> +AC_PATH_PROG([PERL], [perl])
> +
>  AC_ARG_ENABLE([with-test-suite],
>                AC_HELP_STRING([--with-test-suite], [build test suite by
> default @<:@default=check@:>@]),
>                [case "${withval}" in
> 

ACK of course when squashed with the previous PERL one.

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]