[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 0/4] double close() fixes



On 05/30/2012 09:43 PM, Eric Blake wrote:
> Updated version of Wen's and my patches.  In this version, I
> fixed review comments, split Wen's patch into 3, and tracked
> down when each bug was introduced.
> 
> Eric Blake (2):
>   command: avoid double close bugs
>   fdstream: avoid double close bug
> 
> Wen Congyang (2):
>   command: check for fork error before closing fd
>   qemu: avoid closing fd more than once

I've gone ahead and pushed this series.  My patch 2/4 differs slightly
from Wen's 1/3 on his repost, but the principle is the same - transfer
semantics means that fds[] no longer need to be closed because another
variable tracks them.  Meanwhile, my 1/4 fixed the only thing found
wrong by Wen in v1, and my 3/4 and 4/4 are identical to Wen's latest
repost with nicer commit messages.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]