[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fixes for check and rpm builds without sanlock (and qemu)



Hi Eric,
Compiling error still exists:
<snip>
  Considering target file `test_libvirt_sanlock.aug'.
   File `test_libvirt_sanlock.aug' does not exist.
    Considering target file `locking/test_libvirt_sanlock.aug.in'.
     File `locking/test_libvirt_sanlock.aug.in' does not exist.
     Finished prerequisites of target file `locking/test_libvirt_sanlock.aug.in'.
    Must remake target `locking/test_libvirt_sanlock.aug.in'.
make[3]: Entering directory `/home/ajia/Workspace/libvirt/src'
make[3]: *** No rule to make target `locking/test_libvirt_sanlock.aug.in', needed by `test_libvirt_sanlock.aug'.  Stop.
</snip>

Regards,
Alex

----- Original Message -----
From: "Eric Blake" <eblake redhat com>
To: "Martin Kletzander" <mkletzan redhat com>
Cc: libvir-list redhat com
Sent: Thursday, May 31, 2012 1:03:44 AM
Subject: Re: [libvirt] [PATCH] Fixes for check and rpm builds without sanlock (and qemu)

On 05/30/2012 10:59 AM, Martin Kletzander wrote:
> On 05/30/2012 05:50 PM, Eric Blake wrote:
>> On 05/30/2012 09:35 AM, Martin Kletzander wrote:
>>> Apart from the non-sanlock check build, there is also a little fix for
>>> qemu (EXTRA_DIST had qemu.conf and others inside even if the build was
>>> supposed to be without qemu).
>>> ---

> Thanks, ACK'd hunks are pushed, the NACK'd one was just my
> misunderstanding, it doesn't do anything wrong.
> 
> However, I didn't change the commit message, so it maybe a little
> confusing and I realized it after the push. What's the best way to solve
> that?

Oh well.  It's not worth rewinding history just to change a bad commit
message, and this isn't the first time a commit message is a bit out of
date with the actual contents of the change.  We'll just have to live
with it :)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--
libvir-list mailing list
libvir-list redhat com
https://www.redhat.com/mailman/listinfo/libvir-list


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]