[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 06/11] Make QEMU perform managed save of all VMs on stop of libvirtd



> +    /* Then we save the VMs to disk */
> +    for (i = 0 ; i < numDomains ; i++)
> +        if (virDomainManagedSave(domains[i], flags[i]) < 0)
> +            ret = -1;

Ok, so if any save fails we will report an error.

> +    VIR_FREE(domains);
> +    VIR_FREE(flags);
> +
> +    ret = 0;

Eh, I guess not?
I think we should though.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]