[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 0/2] qemu: Fix incorrect qemuDomainGetBlockIoTune() results



The qemuDomainGetBlockIoTune() function was returning incorrect results as I
discovered on Fedora Virt Test Day:
https://fedoraproject.org/wiki/QA:Testcase_Virtualization_IO_Throttling

The problem is that I/O limits can be set but I only see zeroes when displaying
them with "virsh blkdeviotune <domain> <device>" on a domain with two disks.

First, we're comparing guest device names ("virtio-blk-0") instead of host
device names ("drive-virtio-blk-0").  Second, the JSON monitor code has
inverted string compare logic so we were skipping the device we were looking
for.

These patches make "virsh blkdeviotune" report correct results.

Stefan Hajnoczi (2):
  qemu: Keep QEMU host drive prefix in BlkIoTune
  qemu: Fix device name comparison in
    qemuMonitorJSONBlockIoThrottleInfo()

 src/qemu/qemu_monitor_json.c | 5 +----
 src/qemu/qemu_monitor_text.c | 3 ---
 2 files changed, 1 insertion(+), 7 deletions(-)

-- 
1.7.12.1


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]