[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 06/20] snapshot: Add flag to enable creating checkpoints in paused state



On 11/01/2012 07:12 AM, Peter Krempa wrote:
> On 10/31/12 23:12, Eric Blake wrote:
>> On 10/23/2012 09:12 AM, Peter Krempa wrote:
>>> The default behavior while creating external checkpoints is to let the
>>> guest run while the memory state is caputred. This leads to a larger
>>> save file but minimizes the time needed to take the checkpoint.
>>>
>>> This patch adds a flag that causes the guest to be paused before taking
>>> the snapshot.
>>
>>>       *include/libvirt/libvirt.h.in:
>>>          - add new paused reason: VIR_DOMAIN_PAUSED_SNAPSHOT
>>>          - add new flag for takin snapshot:
>>> VIR_DOMAIN_SNAPSHOT_CREATE_LIVE
>>

>> This misses examples/domain-events/events-c/event-test.c, which also
>> needs updates.
> 
> Hm, the event-test file uses switch() statements that fully cover all
> possible values and I didn't run into a compile problem with this.
> 
> What am I missing here?

Maybe it's me missing something - I think I mixed up events with
reasons.  You weren't adding a new event or life cycle state, just new
detail to an existing life cycle state.  It's just that the events and
the reasons tend to match, so maybe we're missing an event?  I'll look
at it again in v2.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]