[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/2] qemu: Fix incorrect qemuDomainGetBlockIoTune() results



On 11/01/2012 11:20 AM, Stefan Hajnoczi wrote:
> The qemuDomainGetBlockIoTune() function was returning incorrect results as I
> discovered on Fedora Virt Test Day:
> https://fedoraproject.org/wiki/QA:Testcase_Virtualization_IO_Throttling
> 
> The problem is that I/O limits can be set but I only see zeroes when displaying
> them with "virsh blkdeviotune <domain> <device>" on a domain with two disks.
> 
> First, we're comparing guest device names ("virtio-blk-0") instead of host
> device names ("drive-virtio-blk-0").  Second, the JSON monitor code has
> inverted string compare logic so we were skipping the device we were looking
> for.
> 
> These patches make "virsh blkdeviotune" report correct results.
> 
> Stefan Hajnoczi (2):
>   qemu: Keep QEMU host drive prefix in BlkIoTune
>   qemu: Fix device name comparison in
>     qemuMonitorJSONBlockIoThrottleInfo()

ACK series, and I'll push shortly.  Nice that the test day is just
before the 1.0.0 release!  I'll also push into the v0.10.2-maint branch,
so this will hit the next F18 build of libvirt.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]