[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH][reordered] gitignore: ignore more files



On 11/02/2012 05:05 AM, Peter Krempa wrote:
> On 11/01/12 10:30, liguang wrote:
>> ignore *.patch, cscope.po.out, cscope.in.out
>>
>> Signed-off-by: liguang <lig fnst cn fujitsu com>
>> ---
>>   .gitignore |    3 +++
>>   1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/.gitignore b/.gitignore
>> index 1cd2d45..3672131 100644
>> --- a/.gitignore
>> +++ b/.gitignore
>> @@ -13,6 +13,7 @@
>>   *.loT
>>   *.o
>>   *.orig
>> +*.patch
> 
> Hm, also I'd prefer having .patch kept unignored for two reasons:
> 1) there are several .patch files in the tree:
> 
> $ git ls-files | grep "\.patch"
> docs/api_extension/0001-add-to-xml.patch

> so changes to these would pose problems

Not if we also add an inclusion rule:
!/docs/api_extension/*.patch

> 
> 2) this actually reminds you clean your tree before pushing changes and
> removes the possibility of accidentally sending wrong patches with
> "git send-email *.patch"

This reason I agree with, and concur with NACK'ing the patch.  If you
want to ignore .patch files locally, then:

echo '*.patch' >> .git/info/exclude

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]