[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 04/20] snapshot: merge pre-snapshot checks



On 11/01/2012 10:22 AM, Peter Krempa wrote:
> From: Eric Blake <eblake redhat com>
> 
> Both system checkpoint snapshots and disk snapshots were iterating
> over all disks, doing a final sanity check before doing any work.
> But since future patches will allow offline snapshots to be either
> external or internal, it makes sense to share the pass over all
> disks, and then relax restrictions in that pass as new modes are
> implemented.  Future patches can then handle external disks when
> the domain is offline, then handle offline --disk-snapshot, and
> finally, combine with migration to file to gain a complete external
> system checkpoint snapshot of an active domain without using 'savevm'.
> 
> * src/qemu/qemu_driver.c (qemuDomainSnapshotDiskPrepare)
> (qemuDomainSnapshotIsAllowed): Merge...
> (qemuDomainSnapshotPrepare): ...into one function.
> (qemuDomainSnapshotCreateXML): Update caller.
> ---
>  src/qemu/qemu_driver.c | 92 +++++++++++++++++++-------------------------------
>  1 file changed, 34 insertions(+), 58 deletions(-)

I've pushed 1-4, based on ACKs previously received, and after rebasing
to mention 1.0.1 where needed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]