[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: prefer mkostemp for multi-thread safety



On Fri, Nov 2, 2012 at 4:16 PM, Eric Blake <eblake redhat com> wrote:
> On 11/02/2012 03:39 AM, Leonardo Arena wrote:
>>>> It worked.
>>>> I've closed BZ871756.
>>>>
>>>> Thanks to all.
>>>>
>>>> - leonardo
>>>>
>>>
>>> And thanks to you as well.  Let us know how the 1.0.0 turns out as it is
>>> already released.
>>
>> I've already pushed it to Alpine "edge" repository this morning. It will be included in Alpine 2.5 release, scheduled next week.
>
> Alas, 1.0.0 is slightly broken on Alpine.  You need to manually remove
> the mistaken __UCLIBC__ hunk in src/util/logging.c, so that you are
> properly using mkostemp from gnulib and not discarding O_CLOEXEC.  It
> has since been fixed in libvirt.git (this regression cost us three
> additional commits to get straightened out: 30b398d, bd0cb27, d055498).

Yes, I realized that. Thanks for pointing it out though.

Kind regards,
- leonardo


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]