[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v12] support offline migration



在 2012-11-02五的 11:42 -0500,Doug Goldstein写道:
> On Thu, Nov 1, 2012 at 8:30 PM, liguang <lig fnst cn fujitsu com> wrote:
> > original migration did not aware of offline case,
> > so, try to support offline migration quietly
> > (did not disturb original migration) by pass
> > VIR_MIGRATE_OFFLINE flag to migration APIs if only
> > the domain is really inactive, and
> > migration process will not puzzled by domain
> > offline and exit unexpectedly.
> > these changes did not take care of disk images the
> > domain required, for them could be transferred by
> > other APIs as suggested, then VIR_MIGRATE_OFFLINE
> > should not combined with VIR_MIGRATE_NON_SHARED_*.
> > if you want a persistent migration,
> > you should  do "virsh migrate --persistent" youself.
> >
> > v12:
> > rebased for conflicting with commit 2f3e2c0c434218a3d656c08779cb98b327170e11,
> > and take in some messages from Doug Goldstein's patch
> > https://www.redhat.com/archives/libvir-list/2012-October/msg00957.html
> >
> > Signed-off-by: liguang <lig fnst cn fujitsu com>
> > ---
> 
> Unfortunately the patch only pulled in my wording on the error
> messages and not any of my other changes. Jiri's review saw all the
> same issues I saw and corrected in my patch. The only reason I
> submitted a patch is that I've had these same review comments in the
> previous 9 iterations and they weren't getting addressed.
> 
> You've sent e-mails complaining that its taking a long time to get
> your patch merged into master yet you're not addressing code review
> comments and then when someone does the work you aren't pulling it in.
> I'm not giving you these comments as something to cherry pick what you
> agree with and disagree with.
> 
> Please address all the review comments (Daniel, Jiri and myself)
> before you submit your next revision.

OK, I'm trying to address them.

> 
> --
> Doug

-- 
liguang    lig fnst cn fujitsu com
FNST linux kernel team



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]