[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Don't corrupt pointer in qemuDomainSaveMemory()



On 11/06/12 14:21, Eric Blake wrote:
On 11/06/2012 03:07 AM, Peter Krempa wrote:
The code that was split out into the qemuDomainSaveMemory expands the
pointer containing the XML description of the domain that it gets from
higher layers. If the pointer changes the old one is invalid and the
upper layer function tries to free it causing an abort.

This patch changes the expansion of the original string to a new
alocation and copy of the contents.

s/alocation/allocation/

---
  src/qemu/qemu_driver.c | 10 +++++++---
  1 file changed, 7 insertions(+), 3 deletions(-)

ACK.  Good find, and hidden enough that I can see how I missed it in the
first review.

I fixed the commit message and pushed the patch.

Thanks.

Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]