[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'



On 11/06/2012 07:31 AM, Laine Stump wrote:
> On 11/06/2012 03:30 AM, Viktor Mihajlovski wrote:
>> On 11/05/2012 08:59 PM, Eric Blake wrote:
>>> @@ -1523,6 +1524,7 @@ be hot-plugged the next time the domain is
>>> booted.  As such, it must only be
>>>   used with the I<--config> flag, and not with the I<--live> flag.
>>>
>>>   =item B<shutdown> I<domain> [I<--mode acpi|agent>]
>>> +=item B<stop> I<domain> [I<--mode acpi|agent>]
>>>
>> Same suggestion: first line stop, second shutdown.
>>
>>
> 
> And one final thing I didn't notice if anybody had mentioned yet (and
> don't have time to look for now, since I'm off to wait in line to vote):
> it's *very* important that every mention of the "old" verbs note that it
> is a deprecated synonym for the new verb (or at least that it's a
> synonym). We don't want people thinking that there are two different
> commands because they are slightly different in behavior, then getting
> confused about which to use.

Oops, just pushed before seeing this mail; I'll add this as a followup
patch:

diff --git i/tools/virsh.pod w/tools/virsh.pod
index 7a46ffd..d507455 100644
--- i/tools/virsh.pod
+++ w/tools/virsh.pod
@@ -1140,6 +1140,8 @@ By default the hypervisor will try to pick a
suitable shutdown
 method. To specify an alternative method, the I<--mode> parameter
 can specify C<acpi> or C<agent>.

+The command B<restart> is an alias for the older B<reboot>.
+
 =item B<reset> I<domain>

 Reset a domain immediately without any guest shutdown. B<reset>
@@ -1545,6 +1547,8 @@ By default the hypervisor will try to pick a
suitable shutdown
 method. To specify an alternative method, the I<--mode> parameter
 can specify C<acpi> or C<agent>.

+The command B<stop> is an alias for the older B<shutdown>.
+
 =item B<start> I<domain-name-or-uuid> [I<--console>] [I<--paused>]
 [I<--autodestroy>] [I<--bypass-cache>] [I<--force-boot>]
 =item B<boot> I<domain-name-or-uuid> [I<--console>] [I<--paused>]
@@ -1562,6 +1566,8 @@ the restore will avoid the file system cache,
although this may slow
 down the operation.  If I<--force-boot> is specified, then any
 managedsave state is discarded and a fresh boot occurs.

+The command B<boot> is an alias for the older B<start>.
+
 =item B<suspend> I<domain>

 Suspend a running domain. It is kept in memory but won't be scheduled

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]