[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 00/20] External snapshot support



On 11/01/2012 10:22 AM, Peter Krempa wrote:
> This is a second spin of the patches:
> 
> Changes to previous version:
> - pushed fix for private_syms file
> 
> patches 1-4 are Eric's patches that this series builds upon
> patches 5,were ACKed in v1
> patches 6,7,9,10,14 are fixed versions after review
> patch 8 is new in the series
> the rest needs review.
> 
> You can fetch the changes at:
> git fetch git://pipo.sk/pipo/libvirt.git snap-revert

I've now reviewed the series, and have some serious design questions
about what we want to be doing in the last few patches (probably best by
adding new flags in libvirt.in.h, affecting all of create, revert, and
delete, in order to do some fused operations).

Not covered in those reviews, but related to this series - we need a
patch to virsh snapshot-create-as to make it easy to specify that we
want an external checkpoint; maybe by copying after --diskspec,
something like --memspec snapshot=external,file=/path/to/file

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]