[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] virsh: add snapshot-create-as memspec support



On 11/07/2012 04:30 AM, Peter Krempa wrote:
> On 11/07/12 07:48, Doug Goldstein wrote:
>> On Tue, Nov 6, 2012 at 10:00 PM, Eric Blake <eblake redhat com> wrote:
>>> External checkpoints could be created with snapshot-create, but
>>> without libvirt supplying a default name for the memory file,
>>> it is essential to add a new argument to snapshot-create-as to
>>> allow the user to choose the memory file name.  This adds the
>>> option --memspec [file=]name[,snapshot=type], where type can
>>> be none, internal, or external.  For an example,
>>>
>>> virsh snapshot-create-as $dom --memspec /path/to/file
>>>
>>> is the shortest possible command line for creating an external
>>> checkpoint, named after the current timestamp.
>>>

> ACK to the patch. Hm, it would be great to have the ability to have
> auto-generated file names for memory images for external checkpoints
> unfortunately there's the issue with the location as we don't have any
> template. I think we are good for now, but we might consider adding a
> default location of those.

Thanks for the reviews; I'm adding a comment to patch 1 and pushing the
series.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]