[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix "virsh create" example



On Wed, Nov 7, 2012 at 8:02 PM, Doug Goldstein <cardoe gentoo org> wrote:
> On Wed, Nov 7, 2012 at 3:46 PM, Eric Blake <eblake redhat com> wrote:
>> On 11/07/2012 02:16 PM, Guido Günther wrote:
>>> We require a file and don't accept standard input:
>>>
>>> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=692322
>>> ---
>>>  tools/virsh.pod |    2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> ACK.
>>
>> [We SHOULD accept stdin, perhaps only with the magic file name of '-',
>> but that's a lot more plumbing and affects a lot more commands, so this
>> is good for now]
>>
>>>
>>> diff --git a/tools/virsh.pod b/tools/virsh.pod
>>> index 0808d72..0984e6e 100644
>>> --- a/tools/virsh.pod
>>> +++ b/tools/virsh.pod
>>> @@ -553,7 +553,7 @@ B<Example>
>>>
>>>   virsh dumpxml <domain> > domain.xml
>>>   vi domain.xml (or make changes with your other text editor)
>>> - virsh create < domain.xml
>>> + virsh create domain.xml
>>>
>>>  =item B<define> I<FILE>
>>>
>>>
>>
>> --
>> Eric Blake   eblake redhat com    +1-919-301-3266
>> Libvirt virtualization library http://libvirt.org
>
> I would actually go with the "-" case as well. Eric you actually
> reviewed a patch a long while back (remember because I had hoped the
> submitter would fix the code and resubmit)
>
> http://www.redhat.com/archives/libvir-list/2011-June/msg00548.html
>
> I'd be willing to resolve the issues and get that version in, so I'd
> NACK this patch.
>
> --
> Doug Goldstein

The other in the series:
http://www.redhat.com/archives/libvir-list/2011-June/msg00549.html


-- 
Doug Goldstein


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]