[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] docs: Add documents for memory device



On Wed, Nov 07, 2012 at 05:40:41PM +0800, Osier Yang wrote:
> Considering there could be other memory related devices in future,
> this introduces a general device model, called memory device,
> instead of a specific device like "ivshmem", currently only
> "ivshmem" is supported though.
> 
> An example of the XML:
> 
>   <memory model='ivshmem'>

Since we have many sub-elements, I think it is preferrable to
also have the model in a subelement as we do with things like
disk/network/etc

>     <source id='nahanni' path='/tmp/nahanni'/>

Use '/dev/shm' as the example path since that's more usual

>     <size unit='M'>512</size>
>     <vectors>8</vectors>
>     </ioeventfd>

Typo with the '/' location

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]