[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] qemu: refactor graphics code to not hardcode a single display



On 11/08/2012 07:04 AM, Daniel P. Berrange wrote:
> On Thu, Nov 08, 2012 at 09:48:55AM +0100, Alon Levy wrote:
>> The check for a single display remains so no new functionality is added.
>> ---
>>
>> Concerning both patches, I've tested running with all three
>> simultaneously (sdl+spice+vnc) and with spice+vnc, using a
>> single qxl device.
>>
>>  src/qemu/qemu_command.c | 2425 ++++++++++++++++++++++++-----------------------
>>  src/qemu/qemu_process.c |   70 +-
>>  2 files changed, 1259 insertions(+), 1236 deletions(-)
> 
> I'm not really sure what has happened here, but you have got
> an absolutely enourmous diff here. I would expect this patch
> to only affect the small part of qemuBuildCommandLine that
> actually deals with graphics devices. As it is now, it is
> impossible to review this patch I'm afraid :-(

'git diff --patience' to the rescue:

$ git diff HEAD^ --stat
 src/qemu/qemu_command.c | 2425
++++++++++++++++++++++++-----------------------
 src/qemu/qemu_process.c |   70 +-
 2 files changed, 1259 insertions(+), 1236 deletions(-)
$ git diff HEAD^ --stat --patience
 src/qemu/qemu_command.c | 647
+++++++++++++++++++++++++-----------------------
 src/qemu/qemu_process.c |  70 +++---
 2 files changed, 370 insertions(+), 347 deletions(-)

I'll send the patience version of the patch as a followup for easier review.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]