[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2 RESEND] qemu: refactor graphics code to not hardcode a single display



On Fri, Nov 09, 2012 at 05:14:10 -0500, Alon Levy wrote:
> hmm, I'm not using the enum everywhere, I'll send again after fixing (and use --patience).

Actually it's be better to just get rid of the enum completely and rather
follow libvirt's convention of returning -1 on error and 0 on success. And
call virReportOOMError() directly from qemuBuildGraphicsCommandLine so that
you don't have to care about returning different error values.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]