[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 1/3] nodeinfo: Add check and workaround to guarantee valid cpu topologies



On 11/09/12 10:58, Peter Krempa wrote:
Lately there were a few reports of the output of the virsh nodeinfo
command being inaccurate. This patch tries to avoid that by checking if
the topology actually makes sense. If it doesn't we then report a
synthetic topology that indicates to the user that the host capabilities
should be checked for the actual topology.
---
Diff to v1:
- Re-formatted entries in the nodeinfo structure definition
   (model, memory, cpus, mhz, nodes)
- Changed description to entries in nodeinfo structure
   (sockets, cores, threads)
- fixed topology report for offline cores
- changed the output of faked data into nodeinfo->cores and tweaked tests:
tests/nodeinfodata/linux-x86-test7.expected:
CPUs: 24/24, MHz: 2200, Nodes: 1, Sockets: 1, Cores: 24, Threads: 1
tests/nodeinfodata/linux-x86-test8.expected:
CPUs: 64/64, MHz: 2593, Nodes: 1, Sockets: 1, Cores: 64, Threads: 1
(I'm not going to repost those)
---
  include/libvirt/libvirt.h.in | 24 +++++++++++++-----------
  src/nodeinfo.c               | 37 +++++++++++++++++++++++++++++++------
  2 files changed, 44 insertions(+), 17 deletions(-)


I don't like direct bothering with reviews much, but this might go unnoticed :/

Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]