[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib 1/5] Don't call g_type_init on newer glib



On Tue, Nov 13, 2012 at 06:53:48PM +0100, Zeeshan Ali (Khattak) wrote:
> On Tue, Nov 13, 2012 at 6:30 PM, Christophe Fergeau <cfergeau redhat com> wrote:
> > diff --git a/libvirt-gconfig/tests/test-domain-parse.c b/libvirt-gconfig/tests/test-domain-parse.c
> > index 11880de..33fc7be 100644
> > --- a/libvirt-gconfig/tests/test-domain-parse.c
> > +++ b/libvirt-gconfig/tests/test-domain-parse.c
> > @@ -52,8 +52,6 @@ int main(int argc, char **argv)
> >          return 2;
> >      }
> >
> > -    g_type_init();
> > -
> 
> With g_type_init defined for newer glib, we'll want to keep the
> g_type_init() calls, no?

I didn't mention this in the log, but test-domain-parse calls
gvir_config_init which calls g_type_init() so the call to g_type_init() is
redundant. I'll split that in a separate commit with an explanation.

Christophe

Attachment: pgpcAuZF1gIfE.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]