[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [v0.10.2-maint][PATCH] qemu: Always format CPU topology



On 11/13/2012 08:22 AM, Michal Privoznik wrote:
> From: Jiri Denemark <jdenemar redhat com>
> 
> When libvirt cannot find a suitable CPU model for host CPU (easily
> reproducible by running libvirt in a guest), it would not provide CPU
> topology in capabilities XML either. Even though CPU topology is known
> and can be queried by virNodeGetInfo. With this patch, CPU topology will
> always be provided in capabilities XML regardless on the presence of CPU
> model.
> (cherry picked from commit f1c70100409562c3f402392aa667732e5f89a2c4)
> 
> Conflicts:
> 
>     src/qemu/qemu_capabilities.c
>     src/qemu/qemu_command.c
> 
>     The new code uses capabilities caching.
> ---
> 
> I am not sure about the correct process of this. So if there are some pointers ....

I think you're doing fine - since the backport was not trivial, asking
for review is appropriate.  And calling out both the cherry-pick id and
the changes from upstream is sufficient to understand what you were
doing.  About the only thing missing would be a reference to a bugzilla
that explains why you are doing the backport.

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]