[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] help to create disk images of non-shared migration



On 11/14/2012 01:18 AM, Doug Goldstein wrote:

>> +    if (VIR_ALLOC_N(mig->disk, def->ndisks) < 0)
>> +        goto no_memory;
>> +    if (!driver->qemuImgBinary) {
>> +        virReportError(VIR_ERR_INTERNAL_ERROR,
>> +                       "%s", _("unable to find kvm-img or qemu-img"));
> 
> Use qemuFindQemuImgBinary() instead.
> 

No, that was the goal of patch 1/2 to delete qemuFindQemuImgBinary and
instead guarantee that driver->eqmuImgBinary is alwas set.  But if it is
always set, then there is no need to check for it being NULL here.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]