[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: add bootindex for usb-host and usb-redir devices



On 11/14/2012 07:51 AM, Ján Tomko wrote:
> Allow bootindex to be specified for redirected USB devices and host USB
> devices.
> 
> Bug: https://bugzilla.redhat.com/show_bug.cgi?id=805414
> 
> ---
> Bootindex for these devices is supported since QEMU 1.1.0 (or commit 65bb3a5c)
> but the actual booting from usb-host devices is broken since a844ed84
> (before 1.2.0).
> I haven't tested it with usb-redir yet.
> ---
>  docs/schemas/domaincommon.rng |    3 +++
>  src/conf/domain_conf.h        |    4 ++--
>  src/qemu/qemu_capabilities.c  |   10 ++++++++++
>  src/qemu/qemu_capabilities.h  |    2 ++
>  src/qemu/qemu_command.c       |   37 ++++++++++++++++++++++++++++++-------
>  5 files changed, 47 insertions(+), 9 deletions(-)

> @@ -6439,16 +6451,27 @@ qemuBuildCommandLine(virConnectPtr conn,
>  
>          if (hostdev->info->bootIndex) {
>              if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS ||
> -                hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI) {
> +                (hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI &&
> +                hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB)) {

Indentation looks off here; generally, when wrapping lines with (), the
second line starts after the '(' column, as in:

  (a &&
   b)

ACK with that tweak.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]