[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/5] Use helper functions to format the journal iov array



On 11/14/2012 08:30 AM, Daniel P. Berrange wrote:
> On Wed, Oct 17, 2012 at 08:17:16PM +0200, Miloslav Trmač wrote:
>> This simplifies the top-level code, at the cost of using a little more
>> stack space.  The primary benefit is being able to send more fields
>> without knowing in advance how many of them, and of which types, these
>> fields will be, and without having to individually add buffer variables.
>>
>> The code imposes an upper limit on the total number of iovs/buffers
>> used, and fields that wouldn't fit are silently dropped.  This is not
>> significant in this patch, but will affect the following one.
>>

> ACK
> 

I've applied 1-3; 4 is waiting for a resend, and 5 is too controversial
at the moment.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]