[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv4 0/4] Add initial support for reverting snapshots



On 11/19/12 18:19, Michal Privoznik wrote:
On 19.11.2012 17:06, Peter Krempa wrote:
I'm reposting another version of the series. This version fixes small mistakes
in patches 1-3 and reposts patch 4 as it got missing due to a sending error.


Peter Krempa (4):
   qemu: Split out guts of qemuDomainSaveImageStartVM() to allow reuse
   snapshot: Add flag VIR_DOMAIN_SNAPSHOT_REVERT_STOPPED
   snapshot: Add flag to allow hypervisor restart when reverting
     snapshots
   snapshot: qemu: Implement reverting of external snapshots

  include/libvirt/libvirt.h.in |   3 +
  src/libvirt.c                |  36 ++--
  src/qemu/qemu_driver.c       | 389 ++++++++++++++++++++++++++++++++++++++++---
  tools/virsh-snapshot.c       |   7 +
  tools/virsh.pod              |  19 ++-
  5 files changed, 410 insertions(+), 44 deletions(-)


We should really split qemu_driver.c - which has now ~15K LOC - e.g. by
moving snapshot code to a separate file.

Michal

I'm planing on doing that when the snapshot work starts to wrap up so I don't cause merge conflicts.

Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]