[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [RFC PATCHv2 2/n] snapshot: prepare to parse new XML



On 11/20/12 01:09, Eric Blake wrote:
No semantic change, but prepare for a new mode of parsing where
a new _BRANCH flag requests that the parse look up the existing
snapshot to branch from.

* src/conf/snapshot_conf.h (VIR_DOMAIN_SNAPSHOT_PARSE_BRANCH): New
flag, unused for now.
(virDomainSnapshotDefParseString): Add parameter.
* src/conf/snapshot_conf.c (virDomainSnapshotDefParseString):
Update signature.
* src/esx/esx_driver.c (esxDomainSnapshotCreateXML): Update caller.
* src/qemu/qemu_driver.c (qemuDomainSnapshotLoad): Likewise.
* src/vbox/vbox_tmpl.c (vboxDomainSnapshotCreateXML): Likewise.
* tests/domainsnapshotxml2xmltest.c (testCompareXMLToXMLFiles):
Likewise.
---
  src/conf/snapshot_conf.c          | 4 +++-
  src/conf/snapshot_conf.h          | 2 ++
  src/esx/esx_driver.c              | 2 +-
  src/qemu/qemu_driver.c            | 3 ++-
  src/vbox/vbox_tmpl.c              | 2 +-
  tests/domainsnapshotxml2xmltest.c | 2 +-
  6 files changed, 10 insertions(+), 5 deletions(-)


Sane incremental change. Good for reviewing :)

ACK

Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]