[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/4] tests: update qemuhelptest data



On 11/21/2012 10:44 AM, Michal Privoznik wrote:
> On 20.11.2012 19:47, Ján Tomko wrote:
>> Both generated with
>> qemu-system-x86_64 --help > qemu-1.2.0
>>
>> qemu-system-x86_64 \
>> -device ? \
>> -device pci-assign,? \
>> -device virtio-blk-pci,? \
>> -device virtio-net-pci,? \
>> -device scsi-disk,? \
>> -device PIIX4_PM,? \
>> -device usb-redir,? \
>> -device ide-drive,? \
>> -device usb-host,? 2> qemu-1.2.0-device
>>
>> It seems I missed a few -device flags when doing this last time and I
>> mixed up qemu and qemu-kvm.
>> ---

>> +-net tap[,vlan=n][,name=str][,fd=h][,ifname=name][,script=file][,downscript=dfile][,helper=helper][,sndbuf=nbytes][,vnet_hdr=on|off][,vhost=on|off][,vhostfd=h][,vhostforce=on|off]
>> +                connect the host TAP network interface to VLAN 'n' 
> 
> This line adds a space at EOL.

That space is present in actual qemu output.  This file should be exempt
from our syntax check rules.

> 
> 
> ACK if that's fixed.

There's nothing to fix.  We should be using the qemu output as-is (and
raising an upstream bug report so that 1.3 won't have the trailing
space; except that for 1.3, we won't be scraping -help output, so we
need to figure out how to start testing feature detection in 1.2 and
beyond to match our new QMP usage).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]