[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] libvirt RBD attach regression?



On 11/21/2012 11:06 AM, Scott Sullivan wrote:
> Hello,
> 
> We were able to come up with this patch, which does fix the problem in
> our use case:
> 
> http://pastebin.com/izx40mRd
> 

Pastebins are transient; so reposting here:

> index d01e366..3b37ece 100644
> --- a/src/qemu/qemu_domain.c
> +++ b/src/qemu/qemu_domain.c
>  -2013,6 +2013,10 @@ qemuDomainDetermineDiskChain(struct qemud_driver *driver,
>  {
>      bool probe = driver->allowDiskFormatProbing;
>  
> +    if (disk->type == VIR_DOMAIN_DISK_TYPE_NETWORK) {
> +        return 0;
> +    }
> +
>      if (!disk->src)
>          return 0;

> Interested to hear any feedback on the patch.

That actually looks correct :)  I'll go ahead and commit it in your
name; and thanks again not only for the report, but also for the fix.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]