[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib v2] gobject: Also delete storage volume from its pool's list



On Wed, Nov 21, 2012 at 08:04:36PM +0200, Zeeshan Ali (Khattak) wrote:
> From: "Zeeshan Ali (Khattak)" <zeeshanak gnome org>
> 
> Without this patch, storage pool still lists the volume even after it is
> deleted.
> 
> Related Boxes bug: https://bugzilla.gnome.org/show_bug.cgi?id=688724
> ---
>  .../libvirt-gobject-storage-pool-private.h         | 33 ++++++++++++++++++++++
>  libvirt-gobject/libvirt-gobject-storage-pool.c     | 20 +++++++++++++
>  libvirt-gobject/libvirt-gobject-storage-vol.c      |  3 ++
>  3 files changed, 56 insertions(+)
>  create mode 100644 libvirt-gobject/libvirt-gobject-storage-pool-private.h
> 
> diff --git a/libvirt-gobject/libvirt-gobject-storage-pool-private.h b/libvirt-gobject/libvirt-gobject-storage-pool-private.h
> new file mode 100644
> index 0000000..5492e5b
> --- /dev/null
> +++ b/libvirt-gobject/libvirt-gobject-storage-pool-private.h
> @@ -0,0 +1,33 @@
> +/*
> + * libvirt-gobject-storage-pool-private.h: libvirt gobject integration
> + *
> + * Copyright (C) 2012 Red Hat, Inc.
> + *
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with this library; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307  USA
> + *
> + * Author: Zeeshan Ali (Khattak) <zeeshanak gnome org>
> + */
> +
> +#ifndef __LIBVIRT_GOBJECT_STORAGE_POOL_PRIVATE_H__
> +#define __LIBVIRT_GOBJECT_STORAGE_POOL_PRIVATE_H__
> +
> +G_BEGIN_DECLS
> +
> +G_GNUC_INTERNAL void gvir_storage_pool_delete_vol(GVirStoragePool *pool,
> +                                                  GVirStorageVol *volume);

G_GNUC_INTERNAL isn't strictly needed here given our use of .sym files, but
it makes things more obvious.

Looks good, ACK

Christophe

Attachment: pgpVXLZlNEMqr.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]